Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(map_tf_generator): rework parameters #6233

Merged
merged 4 commits into from
Feb 6, 2024
Merged

refactor(map_tf_generator): rework parameters #6233

merged 4 commits into from
Feb 6, 2024

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Jan 30, 2024 •
edited
Loading

Merge with autowarefoundation/autoware_launch#835

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371.

  • Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.
    • This PR.
  • Create the yaml configs in this package and the autoware_launch repository.
  • Create the schema.
    • This PR.
  • Update Parameters chapter in the readme file.
    • This PR.

Tests performed

Lsim works.
passed check-jsonschema.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jan 30, 2024
@YamatoAndo YamatoAndo mentioned this pull request Jan 30, 2024
Merged
4 tasks
@YamatoAndo YamatoAndo marked this pull request as ready for review January 30, 2024 08:28
SakodaShintaro
SakodaShintaro approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I executed the logging_simulator using AWSIM data and confirmed that autoware works with almost the same evaluation values as before.

I also confirmed that the parameters are displayed correctly with mkdocs serve.

@YamatoAndo YamatoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 31, 2024
@YamatoAndo
add config
4e7cf65 
Signed-off-by: Yamato Ando <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0d10e81) 14.91% compared to head (4e7cf65) 14.40%.
Report is 1 commits behind head on main.

❗ Current head 4e7cf65 differs from pull request most recent head 2762656. Consider uploading reports for the commit 2762656 to get more accurate results

Files Patch % Lines
...map_tf_generator/src/pcd_map_tf_generator_node.cpp 0.00% 2 Missing ⚠️
..._tf_generator/src/vector_map_tf_generator_node.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6233      +/-   ##
==========================================
- Coverage   14.91%   14.40%   -0.52%     
==========================================
  Files        1817     1906      +89     
  Lines      125357   129839    +4482     
  Branches    37640    37571      -69     
==========================================
+ Hits        18697    18699       +2     
- Misses      85651    90146    +4495     
+ Partials    21009    20994      -15
Flag Coverage Δ *Carryforward flag
differential 11.49% <0.00%> (?)
total 14.40% <ø> (-0.52%) ⬇️ Carriedforward from ef7a2b9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YamatoAndo YamatoAndo merged commit 5ed6038 into autowarefoundation:main Feb 6, 2024
16 of 18 checks passed
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Feb 6, 2024
@YamatoAndo @pre-commit-ci @zulfaqar-azmi-t4
refactor(map_tf_generator): rework parameters (autowarefoundation#6233)
95f4eb2 
* refactor(map_tf_generator): rework parameters

Signed-off-by: Yamato Ando <[email protected]>

* add config

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Feb 7, 2024
Merged
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
@YamatoAndo @pre-commit-ci @anhnv3991
refactor(map_tf_generator): rework parameters (autowarefoundation#6233)
7a81191 
* refactor(map_tf_generator): rework parameters

Signed-off-by: Yamato Ando <[email protected]>

* add config

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@YamatoAndo @pre-commit-ci @karishma1911
refactor(map_tf_generator): rework parameters (autowarefoundation#6233)
391d5f0 
* refactor(map_tf_generator): rework parameters

Signed-off-by: Yamato Ando <[email protected]>

* add config

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakodaShintaro SakodaShintaro SakodaShintaro approved these changes

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991 anhnv3991 is a code owner

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi KYabuuchi is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san is a code owner

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto is a code owner

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4 TaikiYamada4 is a code owner

@kminoda kminoda Awaiting requested review from kminoda

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

Assignees
No one assigned
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YamatoAndo @SakodaShintaro